Edit Site: Refactor to remove usage of edited entity state #66922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
commented
Nov 12, 2024
| __( 'Delete template part: %s' ), | ||
| decodeEntities( template.title ) | ||
| ); | ||
| commands.push( { |
There was a problem hiding this comment.
This command comes with its own challenges: Knowing where to redirect the editor after deletion (an information we don't have in the editor package for now), so I'm removing it because it felt to me like a really not that useful command and if we were to implement it, it would be good to support it in all editors.
|
The good thing with this PR is that "edit template" and "go back" commands work both in the site and post editors. |
|
Size Change: +558 B (+0.03%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a9f5a13. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11794122186
|
Mamaduka
approved these changes
Nov 13, 2024
I actually think prop drilling is fine :P but yeah depending how it goes, I feel like the site editor will be just a small wrapper of components that would consume params from. |
In my opinion, it depends on the drilling level :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #66921
What?
As the site editor is growing to become a multi page app, it doesn't really make sense to have an edited post type and context state in it.
That state is forcing us today to have a two synchronization mechanism between the url and the state causing some issues related to performance and some hidden bugs at times.
Ideally the routes would just pass the post type, post id to the editor component. The current PR helps to go in that direction by moving some generic commands into the editor package.
Testing Instructions